Skip to content

DNM: example PR to show how to add a new RBAC resource#14055

Closed
johnstcn wants to merge 20 commits into
mainfrom
cj/howto-add-rbac-frobulation
Closed

DNM: example PR to show how to add a new RBAC resource#14055
johnstcn wants to merge 20 commits into
mainfrom
cj/howto-add-rbac-frobulation

Conversation

@johnstcn
Copy link
Copy Markdown
Member

@johnstcn johnstcn commented Jul 30, 2024 •
edited by dannykopping
Loading

  1. In coderd/rbac/policy/policy.go, add your resources and action definitions.
  2. Run make gen to generate codersdk/rbacresources_gen.go
  3. Update roles in coderd/rbac/roles.go and ensure tests in coderd/rbac pass
  4. Add database tables & authorization
  5. Add API routes & authorization
  6. Add tests

@alwaysmeticulous

This comment was marked as outdated.

Sign in to view
@johnstcn johnstcn marked this pull request as draft July 30, 2024 10:04
@dannykopping dannykopping force-pushed the cj/howto-add-rbac-frobulation branch 2 times, most recently from e24c3fb to ac6f3fd Compare July 31, 2024 11:54
@dannykopping
Database implementation
7e86229 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the cj/howto-add-rbac-frobulation branch from ac6f3fd to 7e86229 Compare July 31, 2024 12:22
@dannykopping
Add auditor role permission
d24bf88 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping mentioned this pull request Jul 31, 2024
Merged
Emyrk
Emyrk reviewed Jul 31, 2024
View reviewed changes
Comment thread coderd/database/dbauthz/dbauthz.go Outdated
@github-actions github-actions Bot added the stale This issue is like stale bread. label Aug 9, 2024
@github-actions github-actions Bot closed this Aug 12, 2024
@dannykopping
Merge branch 'main' of https://github.com/coder/coder into cj/howto-a…
9e749bc 
…dd-rbac-frobulation

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping reopened this Aug 19, 2024
@dannykopping dannykopping removed the stale This issue is like stale bread. label Aug 19, 2024
@github-actions github-actions Bot added the stale This issue is like stale bread. label Aug 27, 2024
@github-actions github-actions Bot closed this Aug 31, 2024
@dannykopping dannykopping reopened this Sep 3, 2024
@github-actions github-actions Bot removed the stale This issue is like stale bread. label Sep 4, 2024
@dannykopping
WIP: org-scope for frobulators
cf9df67 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping force-pushed the cj/howto-add-rbac-frobulation branch from af5ddb1 to cf9df67 Compare September 5, 2024 12:05
@dannykopping
Merge branch 'main' of github.com:coder/coder into cj/howto-add-rbac-…
7c9787a 
…frobulation
@dannykopping
Fixup
0ed8de7 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
RBAC fixup
b15c422 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
Fixtures
cd2bbae 
Signed-off-by: Danny Kopping <danny@coder.com>
Emyrk
Emyrk reviewed Sep 6, 2024
View reviewed changes
Comment thread coderd/coderd.go
Comment thread coderd/frobulators.go
Comment thread coderd/frobulators.go
Comment thread coderd/database/dbauthz/dbauthz.go Outdated
Comment thread coderd/database/dbauthz/dbauthz_test.go Outdated
Comment thread coderd/database/dbgen/dbgen.go Outdated
Comment thread coderd/database/queries/frobulators.sql Outdated
Comment thread coderd/rbac/roles_test.go
johnstcn and others added 2 commits September 9, 2024 08:23
@johnstcn @Emyrk
Apply suggestions from code review
a0b9ec1 
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
@johnstcn
make gen
e53fd08
@johnstcn johnstcn requested a review from Emyrk September 9, 2024 08:28
Emyrk
Emyrk approved these changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Emyrk Emyrk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

All LG! Do not actually merge though!

@johnstcn
Copy link
Copy Markdown
Member Author

johnstcn commented Sep 10, 2024

Thanks @Emyrk @dannykopping ! Closing this out.

@johnstcn johnstcn closed this Sep 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2024
@github-actions github-actions Bot deleted the cj/howto-add-rbac-frobulation branch March 11, 2025 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Emyrk Emyrk Emyrk approved these changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@johnstcn johnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn @Emyrk @dannykopping