chore: use rw.WriteHeader to write responses without bodies#13870
Merged
Conversation
Member
|
We also do this tracing span end too: coder/coderd/httpapi/httpapi.go Lines 166 to 167 in 4160118 We'd be losing that. |
Member
Author
|
yes, but all that span measures is time to encode the body and write it to the wire. I guess we could add a new function that just writes the head and tracks that with a span? |
Member
|
I misread what the span did, this is not a big deal 👍 |
Emyrk
approved these changes
Jul 11, 2024
Emyrk
reviewed
Aug 5, 2024
Comment on lines
-454
to
+428
| | Status | Meaning | Description | Schema | | ||
| | ------ | ------------------------------------------------------- | ----------- | ---------------------------------------- | | ||
| | 200 | [OK](https://tools.ietf.org/html/rfc7231#section-6.3.1) | OK | [codersdk.User](schemas.md#codersdkuser) | | ||
| | Status | Meaning | Description | Schema | | ||
| | ------ | --------------------------------------------------------------- | ----------- | ------ | | ||
| | 204 | [No Content](https://tools.ietf.org/html/rfc7231#section-6.3.5) | No Content | | |
Member
There was a problem hiding this comment.
This was a breaking change that we missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the body gets ignored anyway, so why bother allocating/serializing anything?