chore: update pnpm to v9#13843
Merged
Merged
Conversation
matifali
reviewed
Jul 9, 2024
Member
matifali
left a comment
There was a problem hiding this comment.
golangci-lint versions are mismatched so make lint does not pass in local but passes in CI.
version in CI and dogfood Dockerfile: 1.55.2
version in nix:
golangci-lint version
golangci-lint has version 1.59.1 built with go1.22.5 from v1.59.1 on 19700101-00:00:00
atif@CTAR-ATIF-PC:~/github/coder/coder$ which golangci-lint
/nix/store/fx4p42sdx70hzpzsl71r5zwh8az0p74a-golangci-lint-1.59.1/bin/golangci-lint
Contributor
Author
Ok wow this returns a gigantic number of errors. I'll just pin golangci for now in nix. |
Member
|
Same for Did not check for other tool mismatches. We need to devise a better way to sync development and CI. A workaround is to use the |
aslilac
approved these changes
Jul 9, 2024
kylecarbs
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates
flake.nixto only use one version of nixpkgs and flake-utils.cc @kylecarbs for flake stuffs