Skip to content

chore: upgrade golangci-lint to v1.46.0#1373

Merged
coadler merged 2 commits into
mainfrom
colin/lint-v160
May 10, 2022
Merged

chore: upgrade golangci-lint to v1.46.0#1373
coadler merged 2 commits into
mainfrom
colin/lint-v160

Conversation

@coadler
Copy link
Copy Markdown
Contributor

@coadler coadler commented May 10, 2022 •
edited
Loading

Resolves #1372

@coadler coadler self-assigned this May 10, 2022
@coadler coadler force-pushed the colin/lint-v160 branch from a85fd8b to 983cd3d Compare May 10, 2022 19:38
@coadler coadler changed the title chore: upgrade golangci-lint to v1.60.0 chore: upgrade golangci-lint to v1.46.0 May 10, 2022
@coadler coadler requested a review from kylecarbs May 10, 2022 19:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #1373 (5d49b01) into main (c96d439) will increase coverage by 0.19%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   66.85%   67.05%   +0.19%     
==========================================
  Files         286      288       +2     
  Lines       18693    18748      +55     
  Branches      235      241       +6     
==========================================
+ Hits        12498    12571      +73     
+ Misses       4916     4901      -15     
+ Partials     1279     1276       -3
Flag Coverage Δ
unittest-go-macos-latest 54.10% <66.66%> (+0.17%) ⬆️
unittest-go-postgres- 65.58% <83.33%> (+0.11%) ⬆️
unittest-go-ubuntu-latest 56.39% <66.66%> (-0.02%) ⬇️
unittest-go-windows-2022 52.40% <66.66%> (+0.02%) ⬆️
unittest-js 74.24% <ø> (+0.56%) ⬆️
Impacted Files Coverage Δ
cli/ssh.go 40.76% <ø> (+3.44%) ⬆️
coderd/rbac/authz.go 68.08% <0.00%> (ø)
scripts/apitypings/main.go 0.00% <0.00%> (ø)
coderd/audit/backends/postgres.go 38.46% <100.00%> (-30.77%) ⬇️
coderd/coderdtest/coderdtest.go 98.86% <100.00%> (ø)
coderd/httpmw/oauth2.go 82.71% <100.00%> (ø)
coderd/members.go 76.19% <100.00%> (ø)
coderd/userauth.go 54.16% <100.00%> (ø)
coderd/users.go 61.44% <100.00%> (ø)
coderd/workspaces.go 58.51% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96d439...5d49b01. Read the comment docs.

@coadler coadler merged commit 97a95f1 into main May 10, 2022
@coadler coadler deleted the colin/lint-v160 branch May 10, 2022 21:04
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
chore: upgrade golangci-lint to v1.46.0 (#1373)
6fb4d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels

None yet

Projects

None yet

Milestone

V2 Beta

Development

Successfully merging this pull request may close these issues.

Update golangci-lint to v1.46.0

3 participants

@coadler @kylecarbs @misskniss