Skip to content

fix: external auth device flow, check both queries for errors#12367

Merged
Emyrk merged 6 commits into
mainfrom
stevenmasley/idp_429_fail
Feb 29, 2024
Merged

fix: external auth device flow, check both queries for errors#12367
Emyrk merged 6 commits into
mainfrom
stevenmasley/idp_429_fail

Conversation

@Emyrk
Copy link
Copy Markdown
Member

@Emyrk Emyrk commented Feb 29, 2024

Closes #12366
Screenshot from 2024-02-29 09-37-59

{deviceExchangeError.message}
{deviceExchangeError.detail && (
<span>
<br />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't use <br /> tags 😆

@Emyrk Emyrk marked this pull request as ready for review February 29, 2024 15:43
Emyrk added a commit that referenced this pull request Feb 29, 2024
Required to trigger error condition in fe.
See pull (#12367)
@Emyrk Emyrk merged commit 4006974 into main Feb 29, 2024
@Emyrk Emyrk deleted the stevenmasley/idp_429_fail branch February 29, 2024 19:00
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[External Auth] 429 from device flow can result in infinite loading page

2 participants