fix(site): add tests and improve accessibility for useClickable#12218
Merged
Conversation
Kira-Pilot
reviewed
Feb 21, 2024
| * announce the row's data as part of a larger table) | ||
| * | ||
| * It might not make sense to test this hook until the underlying design | ||
| * problems are fixed. |
Member
There was a problem hiding this comment.
WDYT about moving this into a ticket as well as a note in the milestone?
Contributor
Author
There was a problem hiding this comment.
Yeah, just for documentation/visibility, I think that'd be best.
Wondering if we could use an accessibility milestone, too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 for the hooks milestone
Changes made
useClickableto be much more compliant with WCAG guidelinesuseClickableuseClickableTableRow(see notes)Notes