fix(coderd/healthcheck): add daemon-specific warnings to healthcheck output#11490
Merged
Conversation
- Sorts provisioner daemons by name ascending in output - Adds daemon-specific warnings to healthcheck output - Reword some messages
johnstcn
commented
Jan 8, 2024
mtojek
approved these changes
Jan 8, 2024
mtojek
left a comment
Member
There was a problem hiding this comment.
Left a few comments to address/respond to. Otherwise, it is 👍
| Error *string `json:"error"` | ||
|
|
||
| ProvisionerDaemons []codersdk.ProvisionerDaemon `json:"provisioner_daemons"` | ||
| Items []ProvisionerDaemonsReportItem `json:"items"` |
Member
There was a problem hiding this comment.
In theory, this is API breaking, right?
Member
Author
There was a problem hiding this comment.
Yeah in theory, but the modifications were only merged this morning :-)
|
|
||
| // Ensure stable order for display and for tests | ||
| sort.Slice(daemons, func(i, j int) bool { | ||
| return daemons[i].Name < daemons[j].Name |
Member
There was a problem hiding this comment.
doublecheck: we don't need to sort by other fields? There is no way that the report will contain old entries for provisioners with the same name?
Member
Author
There was a problem hiding this comment.
The database schema requires each provisioner daemon to have a unique name.
mafredri
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11393
Part of #10676