Repository navigation
fix: prevent editing build parameters if template requires active version - #11117
Merged
Merged
Conversation
aslilac
reviewed
Dec 11, 2023
aslilac
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the build parameters form when editing a workspace if the workspace is outdated and its template requires being on the active version. This isn't ideal because a user has to update and then edit the parameters which incurs another workspace build; however, right now the user experiences an error since they aren't allowed to "restart" a workspace when the template setting is enabled.
In order to make this a better experience we need to either support supplying first-time values to template parameters (since we have to update) or we allow editing existing parameters from the update button. I'd like to do the former but it'll require a little design work.
This is more of a stopgap in the meantime.