feat: Move workspaces under organizations#1109
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 66.34% 66.18% -0.16%
==========================================
Files 257 261 +4
Lines 16055 16476 +421
Branches 156 156
==========================================
+ Hits 10652 10905 +253
- Misses 4311 4434 +123
- Partials 1092 1137 +45
Continue to review full report at Codecov.
|
This removes split ownership for workspaces. They are now a resource of organizations and have a designated owner, which is a user. This enables simple administration for commands like: - `coder stop ben/dev` - `coder build logs colin/arch` or if we decide to allow administrators to access workspaces, they could even SSH using this syntax: `coder ssh colin/dev`.
Emyrk
reviewed
Apr 25, 2022
Emyrk
left a comment
Member
There was a problem hiding this comment.
Overall sweet. Love this resource division at the org scope.
For the use case of creating a workspace for another user, I think we should just rely on masquerading 👍
Member
|
I only left minor nits. Will approve when you get to respond @kylecarbs. Wanted to get a response on a few before I approve and auto merge takes over |
Member
Author
|
@Emyrk all fixed up! |
coadler
removed their request for review
April 25, 2022 19:07
Contributor
|
I'll leave this one to Steven |
Emyrk
approved these changes
Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes split ownership for workspaces. They are now
a resource of organizations and have a designated owner,
which is a user.
This enables simple administration for commands like:
coder stop ben/devcoder build logs colin/archor if we decide to allow administrators to access workspaces,
they could even SSH using this syntax:
coder ssh colin/dev.