fix: handle SIGHUP from OpenSSH#10638
Merged
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
5c48787 to
5732ab8
Compare
johnstcn
approved these changes
Nov 13, 2023
dc53c53 to
f8a1944
Compare
0d7aa0c to
d727342
Compare
Contributor
Author
d727342 to
4531089
Compare
mafredri
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where remote forwards are not correctly torn down when using OpenSSH with
coder ssh --stdio. OpenSSH sends a disconnect signal, but then also sends SIGHUP tocoder. Previously, we just exited when we got SIGHUP, and this raced against properly disconnecting.Fixes https://github.com/coder/customers/issues/327