feat: add cli support for --require-active-version#10337
Merged
Conversation
spikecurtis
reviewed
Oct 19, 2023
spikecurtis
approved these changes
Oct 19, 2023
spikecurtis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with a few suggestions/FYIs inline. I don't need to review again before merge
| build, err = client.CreateWorkspaceBuild(ctx, workspace.ID, req) | ||
| // It's possible for a workspace build to fail due to the template requiring starting | ||
| // workspaces with the active version. | ||
| if cerr, ok := codersdk.AsError(err); ok && cerr.StatusCode() == http.StatusUnauthorized { |
Contributor
There was a problem hiding this comment.
Whoops. This should have been 403 Forbidden, not 401 Unauthorized. Despite the name, 401 is for when we failed to authenticate the user. Probably shouldn't change it now, though.
Collaborator
Author
There was a problem hiding this comment.
Yeah that's fair I'll update it in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coder start.fixes #7481