feat!: add sections parameter to template insights#10010
Merged
Conversation
sections parameter to template insightssections parameter to template insights
mtojek
marked this pull request as ready for review
October 3, 2023 12:59
BrunoQuaresma
approved these changes
Oct 3, 2023
mafredri
approved these changes
Oct 3, 2023
mafredri
left a comment
Member
There was a problem hiding this comment.
LGTM! Just a few small comments.
| <TemplateUsagePanel | ||
| sx={{ gridColumn: "span 3" }} | ||
| data={templateInsights?.report.apps_usage} | ||
| data={templateInsights?.report?.apps_usage} |
Member
There was a problem hiding this comment.
Did we not need any change for interval_reports which is now possibly also undefined?
Member
Author
There was a problem hiding this comment.
I will leave it for @BrunoQuaresma to polish the FE side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #9495
This PR adds
sectionsparameter to template insights. The idea is to shrink the endpoint response, and reduce the number of DB calls.Changes:
reportandinterval_reportscan be omitted in/insights/templatessectionsHTTP parameter for/insights/templates(values:report,interval_reports)report