-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Comparing changes
Open a pull request
base repository: coder/coder
base: v2.35.3
head repository: coder/coder
compare: v2.35.4
- 5 commits
- 25 files changed
- 8 contributors
Commits on Jul 27, 2026
-
fix: remove 403 from key failover and cooldown on 401 (#27419) (#27524)
Backport of #27419 Original PR: #27419 — fix: remove 403 from key failover and cooldown on 401 Merge commit: dba45ce Requested by: @ssncferreira
Configuration menu - View commit details
-
Copy full SHA for c9388a1 - Browse repository at this point
Copy the full SHA c9388a1View commit details
Commits on Jul 28, 2026
-
fix(coderd): reject workspace proxy hostname prefixes (#27544) (#27615)
Configuration menu - View commit details
-
Copy full SHA for 3d7904b - Browse repository at this point
Copy the full SHA 3d7904bView commit details
Commits on Aug 5, 2026
-
fix(site): backport admin settings dropdown visibility fix to release…
…/2.35 (#27850) Backport of #27481 to `release/2.35`. ## Problem `canViewAnyOrganization` included `viewAnyMembers`, a permission every user now has because of workspace sharing. This meant the Admin settings dropdown (and the Organizations entry within it) showed up for every user, not just admins. ## Fix - Removed `permissions.viewAnyMembers` from `canViewAnyOrganization` in `site/src/modules/permissions/index.ts`. - Updated `site/e2e/tests/roles.spec.ts` to match, including a new regression test for org members with no roles. ## Note on scope Upstream #27481 also refactored `DeploymentDropdown`/`MobileMenu` into a shared `AdminSettings.tsx` component driven by a single permissions object. That refactor doesn't apply to `release/2.35`: this branch's `DeploymentDropdown` and `MobileMenu` already gate the Admin settings menu with equivalent per-permission checks, so only the actual permission fix and its test coverage are backported here. ## Validation - `pnpm exec biome check` on the two changed files: clean. - Confirmed pre-existing `tsc` errors in this branch are unrelated environment/dependency issues (reproduced identically on a clean `release/2.35` checkout). > 🤖 This PR was created with the help of Coder Agents, and needs a human review. 🧑💻 --------- Co-authored-by: Jeremy Ruppel <jeremy.ruppel@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fe656fc - Browse repository at this point
Copy the full SHA fe656fcView commit details
Commits on Aug 10, 2026
-
fix: update google.golang.org/grpc to v1.82.1 (#27925)
## What Updates `google.golang.org/grpc` from `v1.81.1` → `v1.82.1` on `release/2.35`. ## Why IronBank's scan of Coder **v2.35.3** flagged `google.golang.org/grpc v1.81.1` as vulnerable to **GHSA-hrxh-6v49-42gf** (GO-2026-6061). The relevant exposure is the HTTP/2 Rapid Reset-style DoS; the xDS RBAC auth-bypass half of the advisory is not used by Coder. Fixed in **v1.82.1**. `main` (v1.83.0) and `v2.36.0` (v1.82.1) already carry the fix — this is the backport to `release/2.35`. The matching `release/2.34` backport is tracked separately (ENT-144). ## Change - `go.mod`: `google.golang.org/grpc v1.81.1` → `v1.82.1` - `go.sum`: grpc hash lines only No transitive fan-out — `release/2.35` already had the `x/net` / `protobuf` / `x/sys` / `x/text` versions grpc 1.82.1 requires. ## Validation (local; `golangci-lint` at the CI-pinned v1.64.8) - `go build ./...` — clean - `go vet ./tailnet/... ./codersdk/...` — clean - `golangci-lint run` (full repo) — 0 issues - `go run ./scripts/intxcheck ./...` — clean - `go mod tidy` stable; `go mod verify` OK DB-backed test suites (`make test-postgres`) will run in CI. Linear: ENT-143
Configuration menu - View commit details
-
Copy full SHA for fd5efa5 - Browse repository at this point
Copy the full SHA fd5efa5View commit details -
fix: update github.com/DataDog/dd-trace-go/v2 to v2.8.1 (#27938)
## What Updates `github.com/DataDog/dd-trace-go/v2` from `v2.0.0` → `v2.8.1` (indirect) on `release/2.35`. ## Why `github.com/DataDog/dd-trace-go/v2 v2.0.0` is vulnerable to **CVE-2026-50274**. It is an indirect dependency pulled in by the direct `gopkg.in/DataDog/dd-trace-go.v1 v1.74.0` shim that `coderd/tracing` uses. Flagged by the IronBank scan of Coder v2.35.3. Fixed in **v2.8.1** (matches `v2.36.0`/`main`). Companion to the `release/2.34` backport (ENT-141). ## Change `go get github.com/DataDog/dd-trace-go/v2@v2.8.1 && go mod tidy`. This reproduces the DataDog dependency cluster exactly as shipped on `v2.36.0` — every module added/changed matches `v2.36.0`'s `go.mod` (verified, zero mismatches). Notable transitive effects: - **`go-libddwaf/v3` → `/v4`** (major-version module swap; v3 removed) - `datadog-agent/pkg/*` 0.64.2 → 0.77.0 (plus new `pkg/trace/{log,otel,stats,traceutil}`, `pkg/template`, `pkg/opentelemetry-mapping-go/otlp/attributes`) - `datadog-go/v5` 5.6.0→5.8.3, and bumps to `go-sqllexer`, `sketches-go`, `go-tuf`, `go-runtime-metrics-internal` - `go.opentelemetry.io/collector/{component,pdata,pdata/pprofile,featuregate}` 1.27 → 1.51; dropped `collector/semconv`, `appsec-internal-go`, `Masterminds/semver/v3`, `eapache/queue/v2`, `gogo/protobuf` `go.mod` +34/−31 require lines, `go.sum` +110/−98. All new/changed entries are `// indirect`. ## Validation (local; `golangci-lint` at the CI-pinned v1.64.8) - `go build ./...` — clean - `go vet ./coderd/tracing/... ./codersdk/...` — clean - `go test ./coderd/tracing/...` — ok - `golangci-lint run` (full repo) — 0 issues - `go run ./scripts/intxcheck ./...` — clean - `go mod tidy` stable; `go mod verify` OK DB-backed suites (`make test-postgres`) run in CI. Linear: ENT-142 Co-authored-by: Marcin Tojek <mtojek@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 81add7e - Browse repository at this point
Copy the full SHA 81add7eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.35.3...v2.35.4