Change documentation to use port 8443 instead of port 80#740
Merged
Conversation
code-asher
approved these changes
Jun 3, 2019
Member
|
@deansheather we can merge this right in once the commit is signed. 🔑 |
Member
Author
|
Yeah I can sign it, sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
The current documentation asks users to run
sudo ./code-server -p 80instead of just./code-server. This PR changes the documentation (including all firewall stuff) to use./code-serverand therefore the default port of 8443.I don't think we should encourage users to run this as sudo just to get it working on a root port., especially since the target audience of these guides are people with little server admin experience.
Additionally, this PR makes the insecure certificate guide apply to Firefox in addition to just Chrome, changes the AWS AMI image to 18.04 to match the DO guide (which doesn't specify an Ubuntu version, DO defaults to 18.04), and removes the AWS AMI ID as I think it's different for every AWS region.
Is there an open issue you can link to?
#737