Make assets unique - #518
Merged
Merged
Conversation
code-asher
force-pushed
the
fix/unique-assets
branch
from
April 17, 2019 20:25
aff9984 to
8447916
Compare
code-asher
marked this pull request as ready for review
April 17, 2019 20:38
code-asher
force-pushed
the
fix/unique-assets
branch
from
April 17, 2019 20:42
8447916 to
de460dd
Compare
All CSS and JavaScript files have unique names now. I also moved the login to the /login path in order to ensure the HTML for each page is also unique.
code-asher
force-pushed
the
fix/unique-assets
branch
from
April 17, 2019 20:55
de460dd to
c6e9b0e
Compare
Member
|
Pretty neat. I like it 🎊 |
kylecarbs
approved these changes
Apr 17, 2019
lucacasonato
suggested changes
Apr 17, 2019
code-asher
force-pushed
the
fix/unique-assets
branch
from
April 17, 2019 22:08
c6e9b0e to
662f31b
Compare
code-asher
added a commit
that referenced
this pull request
Jun 19, 2019
* Make all assets unique All CSS and JavaScript files have unique names now. I also moved the login to the /login path in order to ensure the HTML for each page is also unique. * Explicitly include assets to cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/login./and/loginitself which made it so you had to refresh or log in twice in some cases.