Skip to content

feat: add option for disabling file downloads #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 18 commits into from
Apr 13, 2022
Merged

feat: add option for disabling file downloads #5055

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f7417d1
feat(cli): add disable-file-downloads to cli
jsjoeio Mar 31, 2022
dd9a2c3
feat(e2e): add download test
jsjoeio Mar 31, 2022
05e789b
feat(e2e): add downloads disabled test
jsjoeio Mar 31, 2022
cd3f248
refactor(e2e): explain how to debug unexpected close
jsjoeio Apr 1, 2022
8e61aff
feat(patches): add disable file downloads
jsjoeio Apr 1, 2022
36e7191
wip: update diff
jsjoeio Apr 4, 2022
4909569
Update src/node/cli.ts
jsjoeio Apr 5, 2022
491d43a
fixup! add missing common/contextkeys file to patch
jsjoeio Apr 5, 2022
fd581d7
fixup!: update patch
jsjoeio Apr 11, 2022
df8fff6
fixup!: default disable-file-downloads undefined
jsjoeio Apr 11, 2022
384c924
fixup!: combine e2e tests
jsjoeio Apr 11, 2022
b7c164c
fixup!: use different test names
jsjoeio Apr 11, 2022
4ce0ad8
Merge branch 'main' into jsjoeio/issue-2426
jsjoeio Apr 11, 2022
fcc8086
feat: add CS_DISABLE_FILE_DOWNLOADS
jsjoeio Apr 12, 2022
d98a6dd
fixup!: make explicit and cleanup test
jsjoeio Apr 12, 2022
7a3b266
fixup!: use beforeEach
jsjoeio Apr 12, 2022
f20ab8b
Merge branch 'main' into jsjoeio/issue-2426
jsjoeio Apr 12, 2022
5ba6882
Merge branch 'main' into jsjoeio/issue-2426
jsjoeio Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup!: make explicit and cleanup test
  • Loading branch information
@jsjoeio
jsjoeio committed Apr 12, 2022
commit d98a6ddc7af0bb1e8710c589d65a1c2947f5c1df
3 changes: 1 addition & 2 deletions src/node/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ export async function setDefaults(cliArgs: UserProvidedArgs, configArgs?: Config
args.password = process.env.PASSWORD
}

if (process.env.CS_DISABLE_FILE_DOWNLOADS) {
if (process.env.CS_DISABLE_FILE_DOWNLOADS === "1") {
Comment thread
jsjoeio marked this conversation as resolved.
args["disable-file-downloads"] = true
}

Expand All @@ -560,7 +560,6 @@ export async function setDefaults(cliArgs: UserProvidedArgs, configArgs?: Config
delete process.env.PASSWORD
delete process.env.HASHED_PASSWORD
delete process.env.GITHUB_TOKEN
delete process.env.CS_DISABLE_FILE_DOWNLOADS

// Filter duplicate proxy domains and remove any leading `*.`.
const proxyDomains = new Set((args["proxy-domain"] || []).map((d) => d.replace(/^\*\./, "")))
Expand Down
5 changes: 4 additions & 1 deletion test/unit/node/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ describe("parser", () => {
})

it("should use env var CS_DISABLE_FILE_DOWNLOADS", async () => {
process.env.CS_DISABLE_FILE_DOWNLOADS = "0"
process.env.CS_DISABLE_FILE_DOWNLOADS = "1"
const args = parse([])
expect(args).toEqual({})

Expand All @@ -359,6 +359,9 @@ describe("parser", () => {
...defaults,
"disable-file-downloads": true,
})

// Cleanup
delete process.env.CS_DISABLE_FILE_DOWNLOADS
})

it("should error if password passed in", () => {
Expand Down