Skip to content

Update node to 10.15.1 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 11 commits into from
Apr 16, 2019
Merged

Update node to 10.15.1 #472

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ce968b6
Update Node to 10.15.1
code-asher Apr 9, 2019
c42b63e
Remove string replace that was used for oclif
code-asher Apr 9, 2019
aa7956f
Update nbin
code-asher Apr 9, 2019
d0e497f
Package node-pty and spdlog with nbin
code-asher Apr 9, 2019
e9c0c96
Label stderr/stdout from shared process
code-asher Apr 9, 2019
9de6400
Remove fork override
code-asher Apr 9, 2019
827dae6
Prevent "already disposed" errors when trying to kill disposed proxies
code-asher Apr 9, 2019
b05064e
Include spdlog dependencies
code-asher Apr 9, 2019
5bc5040
Shim /node_modules
code-asher Apr 9, 2019
8162e0f
Add node_modules to Docker ignore
code-asher Apr 10, 2019
cc92be0
Update nbin
code-asher Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent "already disposed" errors when trying to kill disposed proxies
  • Loading branch information
@code-asher
code-asher committed Apr 9, 2019
commit 827dae60b7d62c64bf5efc88d195d996e714d03f
7 changes: 4 additions & 3 deletions packages/protocol/src/browser/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,10 @@ export class Client {
* Make a remote call for a proxy's method using proto.
*/
private remoteCall(proxyId: number | Module, method: string, args: any[]): Promise<any> {
if (this.disconnected && typeof proxyId === "number") {
// Can assume killing or closing works because a disconnected proxy
// is disposed on the server's side.
if (typeof proxyId === "number" && (this.disconnected || !this.proxies.has(proxyId))) {
// Can assume killing or closing works because a disconnected proxy is
// disposed on the server's side, and a non-existent proxy has already
// been disposed.
switch (method) {
case "close":
case "kill":
Expand Down