Add error message for incorrect password. Fix issue #55#201
Merged
kylecarbs merged 1 commit intoMar 12, 2019
Conversation
Contributor
Author
|
@nhooyr Can you review this PR? I can't request you as a reviewer and Asher and Kyle probably have a backlog that will last for a while. |
Contributor
|
@kylecarbs why can't he request me as a reviewer? |
nhooyr
suggested changes
Mar 12, 2019
nhooyr
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Issue:
On initial welcome/login screen of binary, no error message is displayed in the event of an incorrect password. (See #55)
Changes:
Adds simple logic and styling for error display. Currently is of identical styling/design to the
coder.comlogin page.Test Environment:
OS: Mac OS High Sierra (10.13.6)
Browser: Google Chrome 72.0.3626.109 (Official Build) (64-bit)
(Result: Pass! Compile was successful and everything functions as expected)
Caveats:
None that I can think of at the moment. (I mean, the error message is hard coded. But this page has only one input and the page only has one purpose and does exactly one thing. So I don't know that this is necessarily a bad thing)