Repository navigation
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…s-dir-when-no-test-dir-present
CLI.tests.validation.mp4 |
⚡️ Codeflash found optimizations for this PR📄 11% (0.11x) speedup for
|
…s-dir-when-no-test-dir-present
…s-dir-when-no-test-dir-present
KRRT7
left a comment
There was a problem hiding this comment.
this is doing malicious commands validations, not path validations we should remove it anyways, also, this is very basic mal input validation that can be bypassed quite easily by someone reading codeflash src, let's just remove it please @mashraf-222 , keep the path validation itself
…s-dir-when-no-test-dir-present
PR Type
Bug fix, Enhancement
Description
Validate tests_root directory existence
Support dict and object config access
Improve error response for invalid path
Use config-relative path resolution
Diagram Walkthrough
File Walkthrough
beta.py
Add tests_root validation and config accessorcodeflash/lsp/beta.py