test(common): change fallback default URL in MockPlatformLocation (angular#44211)

josephperrott · thePunderWoman · commit 29c8feef759a · 2021-11-24T18:55:33.000Z
In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is used as this conveys the same information in tests but is correctly formed. PR Close angular#44211
diff --git a/packages/common/testing/src/mock_platform_location.ts b/packages/common/testing/src/mock_platform_location.ts
@@ -122,7 +122,7 @@ export class MockPlatformLocation implements PlatformLocation {
       this.baseHref = config.appBaseHref || '';
 
       const parsedChanges =
-          this.parseChanges(null, config.startUrl || 'http://<empty>/', this.baseHref);
+          this.parseChanges(null, config.startUrl || 'http://_empty_/', this.baseHref);
       this.urlChanges[0] = {...parsedChanges};
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ export class MockPlatformLocation implements PlatformLocation {`
`122`	`122`	`this.baseHref = config.appBaseHref \|\| '';`
`123`	`123`
`124`	`124`	`const parsedChanges =`
`125`		`- this.parseChanges(null, config.startUrl \|\| 'http://<empty>/', this.baseHref);`
	`125`	`+ this.parseChanges(null, config.startUrl \|\| 'http://_empty_/', this.baseHref);`
`126`	`126`	`this.urlChanges[0] = {...parsedChanges};`
`127`	`127`	`}`
`128`	`128`	`}`