Skip to content

Add codex adapter #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeaholicguy merged 5 commits into from
Feb 26, 2026
Merged

Add codex adapter #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45a6bbb
docs(ai): add codex adapter agent-manager lifecycle docs
codeaholicguy Feb 26, 2026
0757cf1
feat(agent-manager): improve codex process-session matching
codeaholicguy Feb 26, 2026
35b2e70
refactor(agent-manager): simplify codex matching flow
codeaholicguy Feb 26, 2026
8da39eb
test(agent-manager): extend codex adapter matching coverage
codeaholicguy Feb 26, 2026
6a98232
docs(ai): finalize phase 7 and 8 for codex adapter feature
codeaholicguy Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(ai): finalize phase 7 and 8 for codex adapter feature
  • Loading branch information
@codeaholicguy
codeaholicguy committed Feb 26, 2026
commit 6a982321cba3b7153d04ec0aa31bbfb4c8842574
48 changes: 48 additions & 0 deletions docs/ai/implementation/feature-codex-adapter-agent-manager-package.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,51 @@ description: Implementation notes for Codex adapter support in package agent man
- `filterCandidateSessions`
- `rankCandidatesByStartTime`
- replaced repeated `agents.some(...)` PID checks with `assignedPids` set tracking

## Phase 6 Check Implementation (February 26, 2026)

### Alignment Summary

- Overall status: aligned with requirements and design.
- Codex adapter implementation remains package-owned and exported through public entry points.
- CLI registration for `list` and `open` includes `CodexAdapter` and preserves existing command UX boundaries.

### File-by-File Comparison

- `packages/agent-manager/src/adapters/CodexAdapter.ts`
- Implements required adapter contract and process-first list membership.
- Uses configured time-based matching (`etime` start time vs `session_meta.timestamp`) with tolerance and day-window file inclusion.
- Includes simplification refactor helpers and set-based PID/session assignment tracking with no behavior drift.
- `packages/agent-manager/src/adapters/index.ts`
- Exports `CodexAdapter` as designed.
- `packages/agent-manager/src/index.ts`
- Re-exports `CodexAdapter` from package root as designed.
- `packages/cli/src/commands/agent.ts`
- Registers `CodexAdapter` for both list and open manager paths; no CLI presentation logic moved into package.
- `packages/agent-manager/src/__tests__/adapters/CodexAdapter.test.ts`
- Covers core mapping/status behavior plus simplified matching-phase behavior (`cwd`, `missing-cwd`, `any`) and no-session-reuse expectations.

### Deviations / Concerns

- No requirement/design deviations found.
- Residual validation note: full `cli:test` still has known unrelated pre-existing failures outside this feature scope; focused Codex adapter tests pass.

## Phase 8 Code Review (February 26, 2026)

### Findings

1. No blocking correctness, security, or design-alignment issues found in the Codex adapter implementation or CLI integration paths.
2. Non-blocking performance follow-up: `readFirstLine` currently reads full file content (`fs.readFileSync`) before splitting first line in `CodexAdapter`; this is acceptable for current bounded scan but can be optimized later for very large transcripts.
3. Test-phase risk remains low for changed paths (focused suites pass), with residual global coverage/flaky-suite signals tracked as pre-existing workspace-level issues.

### Final Checklist

- Design/requirements match: ✅
- Logic gaps on changed paths: ✅ none identified
- Security concerns introduced: ✅ none identified
- Tests for changed behavior: ✅ focused adapter + CLI command suites pass
- Docs updated across lifecycle phases: ✅

### Review Verdict

- Ready for push/PR from a Phase 8 review perspective.
31 changes: 31 additions & 0 deletions docs/ai/testing/feature-codex-adapter-agent-manager-package.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,34 @@ Coverage and residual gaps:

- Track defects by severity (`blocking`, `major`, `minor`)
- Re-run adapter + command regressions for every bug fix

## Phase 7 Execution (February 26, 2026)

### New Test Coverage Added

- Updated `packages/agent-manager/src/__tests__/adapters/CodexAdapter.test.ts` with:
- missing-cwd phase priority over any-session fallback
- one-session-per-process assignment behavior (no session reuse across PIDs)

### Commands Run

- `npx nx run agent-manager:test -- --runInBand src/__tests__/adapters/CodexAdapter.test.ts` ✅
- 1 suite passed, 13 tests passed
- `npx nx run cli:test -- --runInBand src/__tests__/commands/agent.test.ts` ✅
- 1 suite passed, 5 tests passed
- Nx flagged `cli:test` as flaky (environment-level signal seen previously)
- `npx nx run agent-manager:test -- --coverage` ✅ (tests passed; coverage policy failed)
- 3 suites passed, 51 tests passed

### Coverage Snapshot (`packages/agent-manager`)

- Statements: 40.65%
- Branches: 37.31%
- Functions: 49.05%
- Lines: 41.68%
- `CodexAdapter.ts`: statements 44.64%, branches 38.94%, functions 63.41%, lines 45.53%

### Phase 7 Assessment

- Codex adapter changed paths are covered, including the simplified matching orchestration branches.
- Global 80% thresholds remain unmet due broader package backlog coverage outside this feature scope.