Revert "Revert "enable unusedBlocks everywhere""#9743
Merged
Conversation
Because otherwise IE's getBBox grants it an absurdly large width that breaks block bumping
Contributor
|
LGTM. Nice detective work there... sounds like a headache. |
Contributor
Author
|
Hah, it was definitely a bit of a rabbit hole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9725
The original PR was reverted because bumping of unused blocks back onto the workspace when they were dragged outside the workspace was broken in IE.
We have a clippath within the unused block frame whose width was set to 100%. Turns out that in IE and only IE,
getBBoxon that clippath was returning slightly more than the full width of the workspace, meaning that the block itself also had an overwide bounding box, meaning that we specifically skipped bumping it.The simple fix is to manually assign the width of that element at render time like we do all the other visible elements in that frame.
TODO (in a separate PR): this same problem affects the existing function frames, which were the inspiration for unused block frames. Fix this there, too.