Hide stages non authorized#9723
Closed
Bjvanminnen wants to merge 2 commits into
Closed
Conversation
| end | ||
|
|
||
| def summarize | ||
| def summarize(user) |
Contributor
There was a problem hiding this comment.
Ideally the user-specific data would be returned by UsersHelper#summarize_user_progress. We've intentionally tried to keep these APIs anonymous & cacheable.
(Same for ApiController#script_structure above.)
Contributor
Author
There was a problem hiding this comment.
That makes sense. I think this means what I'll have to do is start out by hiding all lockable stages, then upon getting user progress (something we do asynchronously) unhide the lockable stages as appropriate. This might be kind of weird having new stages suddenly appear, but perhaps not any weirder than having progress appear asynchronously.
Contributor
Author
|
Replaced by #9739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For stages that are lockable, don't show them unless you're (a) an authorized teacher or (b) a student of an authorized teacher.