Stage name alignment depends on presence of teacher info#9717
Merged
Conversation
Member
There was a problem hiding this comment.
You could also use &. syntax for a kind of subclass of stageName.
Member
|
Good question about whether there are examples of stages with a mix.. definitely worth checking with a PM about this. Otherwise LGTM. |
fe35bf2 to
160f1cc
Compare
Contributor
Author
|
Based on complexity, decided to instead just always center. Will push once circle-ci passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have teacher info we top align
When we don't have teacher info, we continue to center align
There's some potential for weirdness (some rows would be centered, others top aligned) if we have a script in which some of the stages have teacher info (i.e. right now this just means if they have a lesson plan link) and others do not. I'm not sure whether such a thing exists.