Maker API Setup Page#9701
Merged
Merged
Conversation
- Float image right. - Format errors and identifiers as code. - Open links in new window.
- Use asset version of board image.
…he conditional bundle requiring.
- Move makerlab dependencies bundle into makerlab/dependencies file - Remove semicolons after ES6 functions
- Add default "waiting" state for steps which haven't been reached. - Refactor to use a promise chain for spin/check/fail handling - Turn off success LEDs after a bit, add extremely necessary thumbs up during song and extra beep at the end
- React-ify board setup HTML
| <div className="setup-status" style={{'fontSize': '26px'}}> | ||
| <SetupStep stepStatus={this.state['status-is-chrome']} | ||
| stepId="is-chrome" | ||
| stepName="Chrome version 33+"/> |
Contributor
There was a problem hiding this comment.
Styleguide says:
<SetupStep
stepStatus={this.state['status-is-chrome']}
stepId="is-chrome"
stepName="Chrome version 33+"
/>| BoardController.prototype.pinMode = function (pin, modeConstant) { | ||
| this.board_.pinMode(pin, modeConstant); | ||
| }; | ||
| const resetComponent = (component) => { |
Contributor
There was a problem hiding this comment.
Our styleguide isn't particular, but I'm actually not a fan of an arrow function in this case; I've been trying to use them only when I want the function to be anonymous, and the pattern here effectively names it.
…bound this functions. Update instructions. Slower setup song.
Contributor
Author
|
Circle passed (they had infra issue, succeeded on retry): https://circleci.com/gh/code-dot-org/code-dot-org/18001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.