DTT#9700
Merged
Merged
Conversation
…Studio.random to also use it
The [`deep` argument of `_.clone` has been removed](https://lodash.com/docs#clone); use `_.cloneDeep` in these cases.
The one-argument version of [`_.zipObject`](https://github.com/lodash/lodash/blob/3.10.1/doc/README.md#_zipobjectprops-values) has become [`_.fromPairs`](https://lodash.com/docs#fromPairs).
The boolean `immediate` option for `_.debounce` has been deprecated, so we should use the `leading` and `trailing` options explicitly.
The [`_.contains`](https://github.com/lodash/lodash/blob/3.10.1/doc/README.md#_includescollection-target-fromindex0) alias has been removed in favor of [`_.includes`](https://lodash.com/docs#includes).
Bind your methods instead
Following the same pattern we did for global locale loading. That was working for netsim tests when you ran the whole suite, but if you used the --entry option some tests would never try to load the global locales, only netsim locales, and it would break again.
Conflicts: apps/src/turtle/api.js apps/src/turtle/turtle.js apps/test/unit/turtle/turtleTest.js
Otherwise, the tip will be mostly hidden, but will still "break" the border of the chat bubble. Also teach ChatBubble how to get skinId and isMinecraft from redux state, and remove the code formerly responsible for passing that state all the way down from TopInstructionsCSF
Lodash's _.debounce no longer executes callbacks immediately for debounce durations of zero. Updated tests to reflect this with delays of 0ms to yield and let the debounce fire. I tried everything I could to get lolex (time simulation library) to work, but lodash stubbornly closes around window.Date so there's not much I can do.
Previously, all our readonly Blockly BlockSpaces were being arbitrarily sized to 100px tall. This meant that short blocks ended up taking up too much space, and tall blocks needed to be scrolled. No more!
…ogress_dots Revert "Peer Review status should show up in puzzle dots"
…params Update the pd-workshop join_section redirect to handle section_code a s a query param
Fix layout of FreeResponse levels inside a LevelGroup
…y-blocks Dynamically resize ReadOnly Blockly
…ixes Top instructions minor bugfixes
…tendance where at least one session has no attendees. Rails converts empty param arrays to nil, which was causing the error. This doesn't happen in the context of a controller unit test however, so I added an integration test to expose and test it.
[test ui] Unrevert progress again
Upgrade to lodash 4
Add 'Jump To' block to Artist
…-fix Fixed NoMethodError for nil:NilClass error from attempting to save at…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.