DTP#9567
Merged
Merged
Conversation
…nto application_helper
- Note: introduces duplication which must be resolved.
…r refactor from staging.
- Scope policy violation checking to Play Lab by checking for studio_ in block names. - Fix constant already defined error.
- Use Promises instead of jQuery Deferreds in program checking logic - Refactor back to single point of truth for shared renderAbusive
test -> levelbuilder
Move decisions based on redux state into pure functions in stateQueries.js (which happens to be a nice way to document our business logic). Test them. Adds a test utility for checking every permutation of a set of boolean arguments, which helps prove that these functions do what we expect.
DTL (Test > Levelbuilder)
…tion-tab-when-readonly
…nity Check for sharing policy violations (privacy / profanity) in project Play Lab apps
Level builder changes
It looks like mixing export statements and exports.* exports makes Babel _angry_. Upgrading testUtils.js to real export statements gets tests passing again.
…apps/package (lb, prod)
…-when-readonly Game Lab: Hide animation tab when readonly
…project Play Lab apps"
Make firebase rake tasks work for envs which don't build apps/package
…rivacy-profanity Revert "Check for sharing policy violations (privacy / profanity) in project Play Lab apps"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All eyes tests past. IE11Win10_i18n failed initially but passed on re-run.