Game Lab: Embed level style fix#9506
Merged
Merged
Conversation
Lets different apps set a different non-responsive visualization column width in the redux store, which TopInstructions uses instead of having a hard-coded value. Not a wonderful, complete solution, but it's a start.
| module.exports = connect(function propsFromStore(state) { | ||
| return { | ||
| isEmbedView: state.pageConstants.isEmbedView, | ||
| embedViewLeftOffset: state.pageConstants.nonResponsiveVisualizationColumnWidth + 20, |
Contributor
There was a problem hiding this comment.
why + 20? Might be worth making this a constant or adding a comment?
Contributor
Author
There was a problem hiding this comment.
The existing margin on App Lab embed levels was a magic 20, so I kept it. I'll extract a constant... somewhere.
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TopInstructionscomponents had hard-coded left offsets for embed levels, which looked wrong on Game Lab levels. This makes that offset configurable per-app.Before:
After:
Testing