shared redux store for all of code-studio#9477
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
It seemed really weird having state.progress.progress, and levelProgress seems like a more accurate description of this regardless.
Contributor
|
LGTM! |
ff84ba4 to
14608f6
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some state I want to put into redux that is not really progress related. Over time, I suspect there will continue to be more stuff that we want to put into redux as well.
This provides a module for creating/getting a single redux store. For now it still only uses a single reducer (progress), such that all that happens is our progress state is nested one level deeper.
Eventually, we'll likely want to combine the redux store in code-studio with that of apps, but that is out of scope for this PR.