Progress redux#9431
Merged
Merged
Conversation
Conflicts: apps/src/code-studio/progress.js apps/test/code-studio/progressTest.js
| _.mapValues(data.levels, | ||
| level => level.submitted ? SUBMITTED_RESULT : level.result) | ||
| ), data.peerReviewsPerformed | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Not entirely sure I'm convinced yet that data.peerReviewsPerformed belongs in this action vs. in its own. I think part of the problem is that mergeProgress isn't really an action - it's what we want to do when we handle the action. Really the action is something like receiveCourseProgress
Contributor
Author
|
@mehalshah Everything should be functionally equivalent here, but I moved things around to make it so that the redux stuff is contained in its own module, and more similar to our other redux usage. Let me know if you see any problems or have any questions. |
Contributor
|
No issues. I'm fine with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to make the progress use of redux more similar to how apps uses it. It tries to move the redux behaviors into their own module so that they are more clearly separated. The redux module contains and action types, action creators, and the reducer.