provide firebase auth.uid to anonymous users. don't rely on uid for retrieving serverTime.#9328
Merged
Merged
Conversation
…etrieving serverTime.
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses pivotal item: https://www.pivotaltracker.com/n/projects/1256654/stories/124202601
This is a quick and dirty solution since it provides an anonymous firebase auth token rather than trying to provide a unique token to new visitors. it's possible that in the future we'll want to somehow obtain the session id which rails is about to assign to the new visitor, so that this id is consistent with the
session.idthey receive on their next visit. This work is tracked by https://www.pivotaltracker.com/story/show/125019481 .