Revert "Revert "Moving channel token logic from levels_helper into models""#9268
Merged
Conversation
| StorageApps.new(storage_id('user')), | ||
| { | ||
| name: 'Untitled Project', | ||
| useFirebase: @level.game.use_firebase_for_new_project?, |
Contributor
There was a problem hiding this comment.
Nit: might be better to merge this in create_channel if it's always @level.game.use_firebase_for_new_project? when data is present.
Contributor
|
LGTM! Feel free to ignore nits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the original issue by calling
storage_idand constructing thestorage_appin the controller scope, and passing that intocreate_channel/find_or_create_channel_token.