add data browser views for editing properties and tables#9252
Merged
Conversation
| propTypes: { | ||
| // from redux state | ||
| tableName: React.PropTypes.string.isRequired, | ||
| view: React.PropTypes.oneOf([DataView.OVERVIEW, DataView.PROPERTIES, DataView.TABLE]), |
Contributor
There was a problem hiding this comment.
I bet you could also do something like oneOf(Object.keys(DataView)). What you have might be better anyways tho, since it might be valuable to see the whole list again.
Member
Author
There was a problem hiding this comment.
I'll take your suggestion -- it seemed weird to have to add things to the list in multiple places, and people can quickly find the source of truth if they need to.
Contributor
|
looks good :) |
deploy-code-org
added a commit
that referenced
this pull request
Jun 29, 2016
ec9efaf Merge pull request #9244 from code-dot-org/mail-6-29-advocacy-filename-fix (Andrew Oberhardt) 70a3ed2 Merge pull request #9252 from code-dot-org/data-browser-views (David Bailey) 77dae49 code review feedback (David Bailey) ca1681c Add TABLE view to data browser (David Bailey) 7c2526b use redux to switch between OVERVIEW and PROPERTIES views in the data browser (David Bailey) 37b7197 Merge pull request #9249 from code-dot-org/revert-9232-internet-video (jeremydstone) b0c00cb Revert "Add What is the Internet video for CSP" (jeremydstone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add data browser views for editing properties and tables. switch between views using redux. the new views are just placeholders for now.
spec: https://docs.google.com/document/d/1UfBgHCisr_8jSt8zHFgJL-XrlLthTrXJQZJwoedGYg4/edit#
screen capture:
