Fixes violations of and reenables Style/UnneededInterpolation.#9183
Merged
Conversation
Contributor
|
I don't have a good sense of whether the irb(main):001:0> {1 => 2}
=> {1=>2}
irb(main):002:0> {1.to_s => 2}
=> {"1"=>2} |
Contributor
|
The other risk is that irb(main):003:0> nil.to_s
=> "" |
Contributor
Author
|
In all cases, I verified that the variable --if not nil-- is a string. Let me go back and confirm that the variable is never nil, I missed that. |
| "abuse type: #{params[:abuse_type]}", | ||
| "user detail:", | ||
| "#{params[:abuse_detail]}" | ||
| params[:abuse_detail] |
Contributor
Author
There was a problem hiding this comment.
Though I can't guarantee that params[:abuse_detail] isn't nil, if it is nil, nothing will happen (body won't end with a blank line).
Contributor
Author
|
Confirmed (see the one comment I added). Nice catch. |
Contributor
|
LGTM. Thanks for doing this cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes generated automatically via
bundle exec rubocop --only Style/UnneededInterpolation --auto-correct. Then manual tweaks.