Fixes violations of and reenables rubocop Lint/EndAlignment.#9140
Merged
Conversation
Contributor
Author
|
Ping. |
Contributor
|
Sorry - looking now |
Contributor
|
LGTM |
| 'cookie.filter_except("NO_CACHE");' | ||
| else | ||
| cookies.map{ |c| extract_cookie(c)}.join + "cookie.filter_except(\"#{cookies.join(',')}\");" | ||
| end |
Contributor
There was a problem hiding this comment.
For Style/AlignParameters we've preferred fixed indentation. I wonder if we should use parens here keep the case statement at a normal indent?
out << (
case cookies
when 'all'
'# Allow all request cookies.'
when 'none'
'cookie.filter_except("NO_CACHE");'
else
cookies.map{ |c| extract_cookie(c)}.join + "cookie.filter_except(\"#{cookies.join(',')}\");"
end
)We've been using this pattern a lot in React (example).
Contributor
Author
There was a problem hiding this comment.
Done (also removed unnecessary assignment of out to empty string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes generated manually. Note also that our code seems to surface a bug in rubocop, as rubocop fails to find the second failure in each of these file.
Might mess around with this, trying to produce a simple example with this failure (trivial examples do not surface the bug), reporting an issue if I am able to do so.