Rename files in pegasus/migrations/ for alphabetization purposes.#9073
Merged
Conversation
Contributor
|
Is this reordering just git incorrectly matching up the files? I suppose it doesn't matter since they're all noop. |
Contributor
|
Looks like all the migrations with actual content matched up correctly. LGTM. Make sure you test migrate & rollback locally just to be sure the 0 prefix doesn't mess up the sequel migrator. |
Contributor
Author
|
Yes, as noted in the summary, git seems to have permuted the files with empty migrations. Though confusing for the history, I see no other harm in this. Running |
cc27b0f to
8217da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://sequel.jeremyevans.net/rdoc/files/doc/migration_rdoc.html#label-IntegerMigrator+Filenames
Unfortunately, despite doing the natural renames (only appending zeroes), git apparently decided to permute the names of the noop files. Presumably this isn't problematic?