Output JS errors encountered during UI tests. [test ui]#8870
Merged
Conversation
| window.onerror = function (msg) { | ||
| window.detectedJSErrors = window.detectedJSErrors || []; | ||
| window.detectedJSErrors.push(msg); | ||
| }; |
Contributor
There was a problem hiding this comment.
we might want to store the original window.onerror if it exists, and then also call it, so that if we depend on a different window.onerror defined elsewhere we're not blowing it away
Contributor
Author
There was a problem hiding this comment.
Ah that's right, like we do in https://github.com/code-dot-org/code-dot-org/blob/staging/code-studio/src/js/code-studio.js#L63-L63 — will update
Contributor
|
I think starting out failing is fine, and if we find that's too problematic we can try dialing back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main drawback of this approach is that it does not catch errors during page load (only after Selenium considers the page sufficiently loaded).
To get page errors on load as well, it looks like we could either (1) use a man-in-the-middle proxy like fiddler or mitmproxy or (2) maybe include the reporting javascript snippet on our pages in the test environment.