Update lodash 2.4.2 -> 4.13.1.#8564
Closed
bcjordan wants to merge 1 commit into
Closed
Conversation
- contains -> includes - update test to remove usage of deprecated boolean option (use explicit object instead)
Contributor
Author
|
@Bjvanminnen it looks like this causes an issue with |
Contributor
|
If we're upgrading in apps, we should probably upgrade in code-studio as well. |
Contributor
|
For the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this upgrade is to enable use of
_.mergeWith(introduced in lodash 4.0) in order to define a merge which concats rather than overwrites arrays (https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/utils.js#L446-L446)_.contains->_.includesUsed in #8563
One small drawback is this increases the built out lodash size a bit.
To investigate: