Added scripts for the 5-2 petition followup mailing.#8162
Conversation
| teachers = query_subscribed_contacts(q: teacher_query, fl: fields) | ||
| puts "#{teachers.length} total US teachers and past HOC organizers." | ||
|
|
||
|
|
There was a problem hiding this comment.
Style/EmptyLines: Extra blank line detected.
|
@ashercodeorg I updated the PR with your suggestions. After consulting with Marketing, i expanded the query to include the experiment emails too. We are sticking with everyone who didn't click through regardless of whether they opened the original email. I added a test query and manually verified I'd get an error for both conditions: completely faulty url, or a valid but incorrect url (i.e. one used in a previous email campaign). |
| # Next, filter for those who did not click through any of the previous petition emails (experiments or final). | ||
| PREVIOUS_MESSAGE_NAME_PREFIX = '4-22-petition-congress%' | ||
| CLICK_THROUGH_URL = 'http://bit.ly/computersciencepetition' | ||
| message_id_list = DB[:poste_messages].where(Sequel.like(:name, PREVIOUS_MESSAGE_NAME_PREFIX)).map(:id).join(',') |
There was a problem hiding this comment.
nit: Long line. Perhaps
message_id_list = DB[:poste_messages].
where(Sequel.like(:name, PREVIOUS_MESSAGE_NAME_PREFIX)).
map(:id).
join(',')
|
Bunch of nits, overall LGTM. Note that the ci/circleci failure seems to be spurious (a JS error). |
187056e to
1740a53
Compare
|
I updated with your suggestions. The unrelated js error has been fixed in #8163, so I rebased and am running the tests again. |
1740a53 to
3b3c8d2
Compare
No description provided.