Toggle color of debug pane while debugging#8157
Conversation
Conflicts: apps/src/templates/CodeWorkspace.jsx
| JSInterpreter.prototype.handleStepOut = function () { | ||
| this.paused = true; | ||
| this.nextStep = StepType.OUT; | ||
| this.studioApp.reduxStore_.dispatch(runState.setIsDebugging(this.paused)); |
There was a problem hiding this comment.
Another option would be to provide a setPaused method, which is the only place that mutates this.paused, and then does the mutation and dispatches our action.
There was a problem hiding this comment.
I think this whole thing needs a refactor at some point but this may not be the PR to do it, anyway.
| var props = this.props; | ||
|
|
||
| // TODO: AnimationTab should likely use components from PaneHeader, at | ||
| // which point purpleHeader style should move in here. |
There was a problem hiding this comment.
This should be addressed in a future PR.
| var experiments = require('../experiments'); | ||
|
|
||
| var BLOCKS_GLYPH_LIGHT = "data:image/gif;base64,R0lGODlhEAAQAIAAAP///////yH+GkNyZWF0ZWQgd2l0aCBHSU1QIG9uIGEgTWFjACH5BAEKAAEALAAAAAAQABAAAAIdjI+py40AowRp2molznBzB3LTIWpGGZEoda7gCxYAOw=="; | ||
| var BLOCKS_GLYPH_DARK = "data:image/gif;base64,R0lGODlhEAAQAIAAAE1XX01XXyH+GkNyZWF0ZWQgd2l0aCBHSU1QIG9uIGEgTWFjACH5BAEKAAEALAAAAAAQABAAAAIdjI+py40AowRp2molznBzB3LTIWpGGZEoda7gCxYAOw=="; |
There was a problem hiding this comment.
Replaced the 256x256 image with a base64 encoded 16x16 image so that we can easily swap between light and dark without having to do an async image load (another option would be to background load in advance). We are losing something, as the original image had slightly rounded rects, but it was being rendered small enough that I don't think I can see the difference.
|
|
||
| var runState = require('@cdo/apps/redux/runState'); | ||
|
|
||
| describe('isRunning reducer', function () { |
|
This looks awesome! LGTM. |
| }, | ||
| headerButtonMinecraft: { | ||
| backgroundColor: '#606060', | ||
| color: '#BFBFBF', |
There was a problem hiding this comment.
These colors are not currently in color.scss. Not sure if we want them to (they're MC only) or what I should call them if we do want them to be.
There was a problem hiding this comment.
shrug I'd be cool with extracting them to constants within this file, if they're only reused here.
Have the color of the header for the debug pane change when debugger is paused:
I think this is ready for review now. I haven't sent through UI/eyes tests since the adhoc creation isn't working right now, but I've done quite a lot of manual testing/comparing with prod.