Unclosable dialog#7937
Merged
Merged
Conversation
| <div tabIndex="-1" className="modal dash_modal in" ref="dialog" onKeyDown={this.closeOnEscape}> | ||
| <div className="modal-body dash_modal_body"> | ||
| <div id="x-close" className="x-close" onClick={this.closeDialog}></div> | ||
| {this.props.uncloseable || <div id="x-close" className="x-close" onClick={this.closeDialog}></div>} |
Contributor
There was a problem hiding this comment.
I would prefer to see this written as !this.props.uncloseable && <div .../> though I'm not sure I can fully justify why. I think maybe because it makes more sense for me to have an expression result in false and display nothing than it does to result in true and display nothing.
Contributor
|
lgtm modulo one comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also broken out of #7905: A simple adjustment to the Dialog giving it an 'uncloseable' mode and allowing it to accept and render more than one child element.