Wrap update in test in a rollback transaction.#7933
Merged
Conversation
| id: 7, name: 'Temporary Teacher', user_type: 'teacher', admin: false | ||
| } | ||
| USERS = [ | ||
| STUDENT, TEACHER, ADMIN, FACILITATOR, SELF_STUDENT, UPDATED_STUDENT, |
Contributor
There was a problem hiding this comment.
I think this line is causing the CI test failure:
NameError: uninitialized constant FakeDashboard::UPDATED_STUDENT
Contributor
|
Nice improvement. Once the CI test failure is fixed this looks good to me. |
Contributor
Author
|
The CI test failures seem to be a combination of silly mistakes (missed removing an undefined constant) and an inaccuracy in the syntax in the comment (now corrected). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per instructions here: https://github.com/code-dot-org/code-dot-org/blob/staging/pegasus/test/fixtures/fake_dashboard.rb#L76