hide ani gif unless we have one#7879
Merged
Merged
Conversation
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome on windows was displaying a small, empty scroll box when topInstructions=true.
Previously we would always call the code in
configureAndShowInstructions_and either hide the wrapper, or leave it visible. However, now when topInstructions is true, we don't callconfigureAndShowInstructions_and it never gets hidden.One option would be to move this portion of the code out of
configureAndShowInstructions_, but it seemed to make more sense to me to hide by default, and unhide when needed. Long term, the React version should just declaratively hide/show based on state.Tested App Lab with and without instructions, and then also tested non-applab levels with and without anigifs.