Skip to content

Allow FreeResponse in LevelGroup levels#7854

Merged
joshlory merged 8 commits into
stagingfrom
free-response-level-group
Apr 14, 2016
Merged

Allow FreeResponse in LevelGroup levels#7854
joshlory merged 8 commits into
stagingfrom
free-response-level-group

Conversation

@joshlory

Copy link
Copy Markdown
Contributor

In order to migrate open-response TextMatch levels to use the FreeResponse level type, FreeResponse levels must work inside LevelGroup assessments.

This change updates the _free_response.html.haml partial so it can be hosted in the _level_group.html.haml partial.

}

.level-group-content {
overflow: hidden;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can comment out this line to remove indentation and it should match the existing layout.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the indentation and it works. Thanks for doing that. I might add additional indentation to get the textarea to line up with the multiple-choice answer indent, but can do that later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to have .level-group { .number {} .content {} } except I worry about naming collisions, so don't worry about that for now :)

@breville

Copy link
Copy Markdown
Member

Is there a PR that includes a sample level and a sample inclusion in a .level_group? Would like to try this out.

@joshlory

Copy link
Copy Markdown
Contributor Author

Pushed the migrated levels to a branch. You should be able to git checkout migrate-free-response-levels then rake seed:scripts.

- last_attempt ||= @last_attempt
- index ||= nil

- if index

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment to explain to a newcomer that index indicates it's part of a LevelGroup?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in ea5915e.

@breville

Copy link
Copy Markdown
Member

lgtm

@joshlory joshlory merged commit bf8aa63 into staging Apr 14, 2016
@joshlory joshlory deleted the free-response-level-group branch April 14, 2016 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants