You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️⚠️⚠️ Detected Storybook eyes differences, see report!
A difference was found in our Storybook front-end visual comparison testing against the staging baseline.
This difference was detected in Applitools Eyes and is viewable in the link above.
Determine whether the differences are expected based on this PR's changes
a. If expected: Before merging this PR, accept the new baselines and re-run this action, it should pass.
b. If not expected: Push updates to this PR to correct the differences.
This will potentially affect a number of places, right? That seems okay, just want to confirm.
Yes. By default, MUI Typography does not add bottom margin because gutterBottom is false. The previous update accidentally forced bottom margin onto all heading variants. This fix keeps the margin controlled by the gutterBottom prop, so headings only get bottom spacing when gutterBottom is explicitly set.
Most of the heading components we use have gutterBottom enabled, meaning they are supposed to have a bottom margin anyway. Only a few should be affected, and I believe they are the two that were caught by the eyes tests earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bethanyaconnor
left a comment
Fixes the
MUI Typographycomponent styles so heading bottom margins are once again controlled by thegutterBottomprop.Links