Move student snapshot prompts into langfuse#74015
Open
lfryemason wants to merge 2 commits into
Open
Conversation
fetch_prompt still called the removed `client` method after it was split into tutor_client/ta_client, raising NoMethodError.
lfryemason
commented
Jul 21, 2026
|
|
||
| def self.fetch_prompt(prompt_name) | ||
| response = client.fetch_prompt(prompt_name) | ||
| response = tutor_client.fetch_prompt(prompt_name) |
Contributor
Author
There was a problem hiding this comment.
This called client, which no longer exists — it was split into tutor_client/ta_client in 3243f04 (#71176), which updated add_dataset_item accordingly but missed this method. Any call to fetch_prompt was raising NoMethodError. Switched to tutor_client since prompt fetching is a tutor-side concern, matching tutor_add_dataset_item below it.
Issue found and comment made by claude
Replace the hardcoded lesson-insight/lesson-feedback system prompts with
{{variable}}-substitution templates fetched from Langfuse (ta_client),
falling back to local constants if the fetch fails. Also add
LangfuseHelper.fetch_ta_prompt and extract the shared response-wrapping
logic out of fetch_tutor_prompt/tutor_add_dataset_item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.