Skip to content

Rebrand Music Lab pack dialog#73649

Draft
ebeastlake wants to merge 1 commit into
stagingfrom
task/rebrand-music-pack-dialog
Draft

Rebrand Music Lab pack dialog#73649
ebeastlake wants to merge 1 commit into
stagingfrom
task/rebrand-music-pack-dialog

Conversation

@ebeastlake

@ebeastlake ebeastlake commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Rebrands the Music Lab pack selection dialog missed in the earlier Music Lab pass.

  • Uses MUI Typography for dialog and row text.
  • Moves modal colors from legacy/raw values to semantic dark-theme tokens.
  • Keeps DSCO SegmentedButtons because the MUI migration status says segmented buttons are not started.
  • Sets the dialog subtree to data-theme="Dark" so the semantic tokens resolve to the dark Music Lab surface.

Testing story

Before entire modal:
Screenshot 2026-07-02 at 4 34 56 PM

After entire modal:
Screenshot 2026-07-02 at 4 34 49 PM

Before select song:
Screenshot 2026-07-02 at 4 35 25 PM

After select song:
Screenshot 2026-07-02 at 4 36 42 PM

Manual QA checklist before marking ready:

  • Open a Music Lab level with no selected pack under ?brand=codeai-next.
  • Confirm the Select a track modal uses the rebrand dark surface, border, typography, and button styling.
  • Switch Popular, Song A-Z, and Artist A-Z modes.
  • Select a row and confirm the selected row state has readable text and the Select button behavior still works.
  • Verify Skip, Select, Escape, tab order, and focus trap behavior.
  • Check desktop widths around 1568, 1280, 1024, and 768 px.
  • Check Firefox or Safari if available.
  • Check RTL if the test environment makes that easy.

Design check:

  • The old alternate row color was raw #363E48. There is no exact semantic dark token for it, so this uses --background-neutral-secondary, which makes the alternating rows stronger.
  • The selected row now uses --background-brand-teal-primary; row text switches to --text-neutral-white-fixed so selected normal-size text passes AA contrast.

Use MUI typography and semantic dark-theme tokens for the Music Lab pack selection dialog.

Co-Authored-By: OpenAI Codex <codex@openai.com>
@ebeastlake ebeastlake force-pushed the task/rebrand-music-pack-dialog branch from c4d9f4f to 4883c1b Compare July 2, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant