Rebrand Music Lab pack dialog#73649
Draft
ebeastlake wants to merge 1 commit into
Draft
Conversation
Use MUI typography and semantic dark-theme tokens for the Music Lab pack selection dialog. Co-Authored-By: OpenAI Codex <codex@openai.com>
c4d9f4f to
4883c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebrands the Music Lab pack selection dialog missed in the earlier Music Lab pass.
data-theme="Dark"so the semantic tokens resolve to the dark Music Lab surface.Testing story
Before entire modal:

After entire modal:

Before select song:

After select song:

Manual QA checklist before marking ready:
?brand=codeai-next.Design check:
#363E48. There is no exact semantic dark token for it, so this uses--background-neutral-secondary, which makes the alternating rows stronger.--background-brand-teal-primary; row text switches to--text-neutral-white-fixedso selected normal-size text passes AA contrast.