feat(craft): convert craft-lab to Vite/vitest/TypeScript workspace#73618
Draft
stephenliang wants to merge 1 commit into
Draft
feat(craft): convert craft-lab to Vite/vitest/TypeScript workspace#73618stephenliang wants to merge 1 commit into
stephenliang wants to merge 1 commit into
Conversation
4 tasks
6a47e72 to
87d6fe9
Compare
…space Convert the subtree-imported craft game engine into a conformant frontend/ workspace package: - Rewrite package.json as @code-dot-org/craft-lab with dual ESM+CJS exports, Vite library-mode build, and vitest test runner - Convert all 47 source files from CommonJS to ES modules - Add Vite config with custom emitCraftAssets plugin and Phaser CE externalization - Migrate unit tests from tape to vitest (64 passing, integration tests marked skip pending Playwright coverage) - Progressive TypeScript adoption: rename 3 key files to .ts, add ambient Phaser type declarations - Add standard workspace config (tsconfig, eslint, lint-staged) - Remove standalone repo tooling (webpack, karma, babel, nyc, codecov) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
87d6fe9 to
e77fe6b
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/workspace package (@code-dot-org/craft-lab)package.jsonwith dual ESM+CJS exports via Vite library mode build.ts, ambient Phaser type declarations,@ts-nocheckon remaining JSContext
Second of 3 stacked PRs for the craft-lab migration. Stacked on #73617.
Test plan
cd frontend/packages/labs/craft && yarn buildproducesdist/index.mjs,dist/index.cjs,dist/index.d.ts, anddist/assets/yarn testruns vitest — 64 unit tests pass, integration tests skippedyarn typecheckpasses with zero errorsdist/index.mjs🤖 Generated with Claude Code