Sketch2: more visible group styling on focus and hover#73615
Open
bencodeorg wants to merge 1 commit into
Open
Conversation
bencodeorg
commented
Jul 1, 2026
| // Declared after hover so it wins when both apply. | ||
| :global(.react-flow__node-group.selected) .groupNode, | ||
| :global(.react-flow__node-group:focus-visible) .groupNode { | ||
| outline: 2px solid var(--borders-brand-teal-primary); |
Contributor
Author
There was a problem hiding this comment.
We have a handful of teal in Sketch Lab (eg, tab nav applies a teal outline on focus), might want to move to something else?
Contributor
There was a problem hiding this comment.
ugh yeah our focus ring will change to purple along with every other instance of teal on the site. Bc the variable names will also be changing, I would just keep it teal for now, we will need to deal with this a large-scale soon anyways 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve styling of groups, both on hover (thicker dotted outline) and focus (thicker line, now blue).