test(e2e): port public_project_gallery_signed_out to Playwright#73614
Open
stephenliang wants to merge 5 commits into
Open
test(e2e): port public_project_gallery_signed_out to Playwright#73614stephenliang wants to merge 5 commits into
stephenliang wants to merge 5 commits into
Conversation
…out to playwright Port 2 scenarios from dashboard/test/ui/features/teacher_tools/projects/public_project_gallery_signed_out.feature. Green under the 5x/all-browser stress gate; original Cucumber feature tagged @playwright so the Cucumber suite skips it. Source: dashboard/test/ui/features/teacher_tools/projects/public_project_gallery_signed_out.feature
The locator `getByRole('heading', {level: 1, name: 'Projects'})` already
guarantees the accessible name; replace tautological `toContainText` with
`toBeVisible`. Drop `toBeAttached` subsumed by the following `toHaveCount(1)`.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Strip verbose docstring and per-field comments (homedir rule) - Rename PublicProjectGallery → PublicProjectGalleryPage (Page suffix) - Replace .ui-featured CSS selector with getByRole heading a11y locator - Drop migration-status comments from spec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… spec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Scoped axe scan on #uitest-public-projects; currently zero violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
public_project_gallery_signed_out.feature(2 Cucumber scenarios) to a Playwright spec atfrontend/packages/e2e-tests/tests/projects/public-project-gallery.spec.tswith a POM attests/pages/public-project-gallery.ts.What changed
PublicProjectGallery): extendsBasePage, exposes locators for the page heading,#uitest-public-projectsgallery container,.ui-project-app-type-areawrappers, and.ui-featuredsection. Navigation viagoto()to/projects/public.public-project-gallery.spec.ts): two tests mirroring the Cucumber scenarios — "Public Gallery Shows Expected Elements" (heading visible, gallery container visible) and "Public Gallery Shows Expected Project Types" (exactly 1 project type area, featured section contains "Featured Projects").@playwrighttag added to the original.featurefile to mark it as ported.Links
public_project_gallery_signed_out.featureTesting story
Stress-tested locally: 30/30 runs passed (5 repeats × 3 browsers — chromium, firefox, webkit — with
--retries=0). Code-reviewed at xhigh effort; two redundant assertions trimmed post-review (redundanttoContainTextsubsumed by locator name filter, redundanttoBeAttachedsubsumed bytoHaveCount).Deployment notes
No deployment impact — test-only change.